Add ability to specify a function doesn't need args fully resolved when used inside let-flow#203
Open
tanzoniteblack wants to merge 1 commit intoclj-commons:masterfrom
Open
Add ability to specify a function doesn't need args fully resolved when used inside let-flow#203tanzoniteblack wants to merge 1 commit intoclj-commons:masterfrom
let-flow#203tanzoniteblack wants to merge 1 commit intoclj-commons:masterfrom
Conversation
…side `let-flow` Some functions, like `d/alt` are designed to handle deferrables as arguments. `let-flow` shouldn't wait on args to functions like these to have been resolved before invoking the function. With this change set, all the functions inside `manifold.deferred` that are designed to work with deferrables will now behave as "expected" inside a `let-flow` block. Users can mark their own functions with the metadata `manifold.deferred/deferred-args` to have `let-flow` treat those the same way.
KingMob
reviewed
Feb 25, 2023
Comment on lines
+148
to
+149
| (is (>= 200 (- (System/currentTimeMillis) start)) | ||
| "Alt in body should only take as long as the first deferred to finish.")) |
Collaborator
There was a problem hiding this comment.
I don't think we can make this change for let-flow bodies, only bindings. The docstring explicitly says "The body will only be executed once all of the let-bound
values, even ones only used for side effects, have been computed.", and some users may be relying on that.
More generally, an alt in the body only makes sense if some of its arguments aren't bound in the let-flow. If all of them are, then it's essentially random, which is fine, but may not be what they expect.
Collaborator
|
Also related to #141 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some functions, like
d/altare designed to handle deferrables as arguments.let-flowshouldn't wait on args to functions like these to have been resolved before invoking the function.
With this change set, all the functions inside
manifold.deferredthat are designed to work withdeferrables will now behave as "expected" inside a
let-flowblock. Users can mark their ownfunctions with the metadata
manifold.deferred/deferred-argsto havelet-flowtreat those thesame way.
Addresses #183
N.B. This includes the changes from #202 , which I've done to not cause merge conflicts between the two change sets.